Comments on: URL Encoding

By: Spencer MacDonald

Spencer MacDonald — Thu, 21 Apr 2011 18:57:19 +0000

Looking at the MKBitlyHelper source code, it escapes the URL that you parse to it before sending it off to bit.ly.

This means that your escaping an already escaped URL, which is likely to be the cause of your problems.

By: Dominic

Dominic — Thu, 21 Apr 2011 07:52:57 +0000

This does not work when using with MKBitlyHelper..

By: Spencer MacDonald

Spencer MacDonald — Tue, 23 Mar 2010 19:40:06 +0000

Thanks Bill,

I noticed this the other day when I did static analysis on one of my projects, but I forgot I did a blog post on it. I have updated the code snippet to the one I know use in my projects.

By: Bill

Bill — Tue, 23 Mar 2010 12:19:36 +0000

This category method is an elegant solution and I’ve got a place where I can use it. Thanks!

By: Bill

Bill — Tue, 23 Mar 2010 12:15:42 +0000

CFURLCreateStringByAddingPercentEscapes() creates an object whose memory you need to manage explicitly. It behaves like malloc() or [[NSString alloc] init]: the memory for the thing returned has to be freed by the caller or you get a leak.

The implementation above will leak two CFStringRefs every time it’s called.

CFStringRef *encoded = CFURLCreateStringByAddingPercentEscapes(kCFAllocatorDefault, (CFStringRef)[parameters valueForKey:key], NULL, CFSTR(“:/?#[]@!$&’()*+,;=”), kCFStringEncodingUTF8);

[urlString appendFormat:@"?%@=%@",key, encoded];

CFRelease(encoded);

Using CoreFoundation objects always seems to add a lot of noise to otherwise clean code. I guess that’s the price we pay, though.