Comments on: URL Encoding http://objcolumnist.com/2009/10/25/escaping-a-url/ Coding under the Hammer Mon, 07 Jun 2010 12:36:06 -0700 hourly 1 http://wordpress.org/?v=abc By: Spencer MacDonald http://objcolumnist.com/2009/10/25/escaping-a-url/comment-page-1/#comment-529 Spencer MacDonald Tue, 23 Mar 2010 19:40:06 +0000 http://objcolumnist.com/?p=137#comment-529 Thanks Bill, I noticed this the other day when I did static analysis on one of my projects, but I forgot I did a blog post on it. I have updated the code snippet to the one I know use in my projects. Thanks Bill,

I noticed this the other day when I did static analysis on one of my projects, but I forgot I did a blog post on it. I have updated the code snippet to the one I know use in my projects.

]]> By: Bill http://objcolumnist.com/2009/10/25/escaping-a-url/comment-page-1/#comment-528 Bill Tue, 23 Mar 2010 12:19:36 +0000 http://objcolumnist.com/?p=137#comment-528 This category method is an elegant solution and I've got a place where I can use it. Thanks! This category method is an elegant solution and I’ve got a place where I can use it. Thanks!

]]> By: Bill http://objcolumnist.com/2009/10/25/escaping-a-url/comment-page-1/#comment-527 Bill Tue, 23 Mar 2010 12:15:42 +0000 http://objcolumnist.com/?p=137#comment-527 CFURLCreateStringByAddingPercentEscapes() creates an object whose memory you need to manage explicitly. It behaves like malloc() or [[NSString alloc] init]: the memory for the thing returned has to be freed by the caller or you get a leak. The implementation above will leak two CFStringRefs every time it's called. CFStringRef *encoded = CFURLCreateStringByAddingPercentEscapes(kCFAllocatorDefault, (CFStringRef)[parameters valueForKey:key], NULL, CFSTR(":/?#[]@!$&’()*+,;="), kCFStringEncodingUTF8); [urlString appendFormat:@"?%@=%@",key, encoded]; CFRelease(encoded); Using CoreFoundation objects always seems to add a lot of noise to otherwise clean code. I guess that's the price we pay, though. CFURLCreateStringByAddingPercentEscapes() creates an object whose memory you need to manage explicitly. It behaves like malloc() or [[NSString alloc] init]: the memory for the thing returned has to be freed by the caller or you get a leak.

The implementation above will leak two CFStringRefs every time it’s called.

CFStringRef *encoded = CFURLCreateStringByAddingPercentEscapes(kCFAllocatorDefault, (CFStringRef)[parameters valueForKey:key], NULL, CFSTR(“:/?#[]@!$&’()*+,;=”), kCFStringEncodingUTF8);

[urlString appendFormat:@"?%@=%@",key, encoded];

CFRelease(encoded);

Using CoreFoundation objects always seems to add a lot of noise to otherwise clean code. I guess that’s the price we pay, though.

]]>